Comment 4 for bug 1399228

Revision history for this message
Cory Johns (johnsca) wrote :

Saurabh,

Thanks for creating this charm and for incorporating the suggestions from Tim. Both charms look good, and the test passes, so I give this my +1 for being promoted to Recommended.

However, there is a bit of a chicken-and-egg problem with it referencing the wilfly-ha-slave charm as a local: charm, since this would fail the automated test runner. Unfortunately, this isn't easily resolvable until both charms are in the recommended namespace in the store, so my recommendation is that, once both charms are promoted, the test is updated to use a cs: reference for the slave charm. The test files also need their permissions to be set to executable so that they will be picked up by the test runner.