Comment 5 for bug 1375790

Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

+1 LGTM, I'll just request the same minor revisions that I did on samhain, if you don't mind. Otherwise looks great!

> bzr diff
=== modified file 'metadata.yaml'
--- metadata.yaml 2014-08-15 11:17:51 +0000
+++ metadata.yaml 2014-10-29 14:30:30 +0000
@@ -4,8 +4,8 @@
 description: |
   Some charms create log files, but don't provide any mechanism to
   rotate them. This fixes that.
-categories:
- - miscellaneous
+tags:
+ - ops
 subordinate: true
 requires:
   juju-info:

=== modified file 'tests/10-basic-tests'
--- tests/10-basic-tests 2014-10-10 08:55:12 +0000
+++ tests/10-basic-tests 2014-10-29 14:26:33 +0000
@@ -1,12 +1,12 @@
-#!/usr/bin/python3
+#!/usr/bin/env python3

 import amulet
 import time

 d = amulet.Deployment(series="trusty")

-d.add('apache2', 'cs:trusty/apache2-4')
-d.add('logrotate', 'cs:~chris-gondolin/trusty/logrotate')
+d.add('apache2')
+d.add('logrotate')

 d.relate('apache2:juju-info', 'logrotate:juju-info')

@@ -20,7 +20,7 @@
 except:
     raise

-unit = d.sentry.unit['apache2/0']
+unit = d.sentry['apache2/0']

 # Check logrotate.d exists
 if "logrotate.d" not in unit.directory_contents("/etc")["directories"]: