© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
Chris,
Thank you for your charm submission. The charm looks great, and with your work-around commit, the tests all pass.
My only suggestion is that the Stand-Alone section of the README is a little confusing / misleading, since, as a subordinate charm, this requires a relation to an existing charm to be deployed. If I'm missing something, though, and there is, in fact, a way to use this charm in a stand-alone fashion, then updating the README with clarifying information would be helpful.
Regardless, the rest of the information and example usage are clear enough, and everything else seems good, so I give it my +1.
Regarding the Review Queue test failure, it looks to be due to a bug in Amulet, but I've been told that it should be fixed with the next release. The work-around is fine for now, and the tests should pass on the next run.
Thanks again for your work!