Submission of new zabbix-agent charm in personal namespace
Bug #1369892 reported by
Samuel Cozannet
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Juju Charms Collection |
Incomplete
|
Undecided
|
Samuel Cozannet |
Bug Description
This is the email to submit my new charm as explained in the charming documentation
To post a comment you must log in.
Samuel,
Thanks so much for this charm submission!
First off, I would just like to clarify that it is not actually necessary to submit a charm for review to add it to your personal namespace. Simply pushing to launchpad under lp:~samuel-cozannet/charms/ is sufficient to allow you and and anyone else to deploy your charm. Charles Butler wrote a good blog post explaining personal namespaces in detail.[1]
We are currently working to improve the documentation and user experience around personal namespaces. I am curious which documentation you are specifically referencing above. I don't suppose you could provide me a link?
Taking a look at your charm, I see that it seems to be an extension of cs:precise/ zabbix- agent with some changes to allow it to install a newer version of the Zabbix agent. If this charm is intended for general use, then it might be better to make these changes as a commit on top of a branch of that charm, so that you can keep up with additional changes from upstream, as well as having the option to submit it as a merge proposal to get your changes added back into the upstream charm. Of course, if this charm is intended for personal use only, this may not be of concern to you. :)
However, if this charm is intended for general use, I'd make a couple of other suggestions, as well:
* You added a README, which is great, but it could stand to include instructions on how to use the charm, as well as some more detailed information. The charm-tools library[2] includes a `charm add readme` command that will create an example README with detailed information about the sections that are useful to include in a README
* It would also be nice if there was a configuration option to control which version of the agent is installed, whether from the stable PPA or from the Zabbix upstream PPA. However, this does add some complexity to the charm, since you would then need to support the user changing the config option at a later point (e.g., to upgrade to the upstream version after having installed from the stable PPA).
Once again, if this charm is intended only for your own personal or limited use, these suggestions can be considered just that.
Regardless, thanks again for your charm submission!
[1]: http:// blog.dasroot. net/the- power-of- community- charming/ /juju.ubuntu. com/docs/ tools-charm- tools.html
[2]: https:/