Comment 4 for bug 1310704

Revision history for this message
Charles Butler (lazypower) wrote :

David,

Thank you for the rapid turn around with the review fixes. I've taken a look at the results and everything looks great. I'm going to promulgate the charm as is, with a request to have the deployments yaml moved into a bundle using the instructions: https://juju.ubuntu.com/docs/charms-bundles.html the process is straight forward and involves another branch with the bundles.yaml and a readme.

Since that's not a serious blocker for this charm, and the tests passed on all the substrates I've run it against (again, thank you for such a high standard of code coverage, this is a great example for future developers looking to reference a "how do I test my charm?")

The promulgation process will take about 15 to 30 minutes for the charm to be ingested into the store. I'll follow up on where the bug management location will be for the landscape team, and final resource link for the landscape charm in launchpad.

The finish line is in your sights! Congrats on making it into the store!