Comment 23 for bug 1291783

Greetings Team,

Thanks again for all the hard work and dedication to making this charm submission. I've taken another look though the charm and deployment and I've got the following notes:

The overall documentation for the charm in the README is still very sparse. The configuration sample on deployment is great, but it doesn't explain where the charm lives in the stack. There's a definite dependency on Openstack with the VSM Gateway that should be clearly called out. As an example

# When deploying with MAAS

The VSM charm should be deployed in the same environment as openstack, as the services relate and depend upon one another.

Another area for improvement would be the manual steps required to configure the service after deployment of the VSM charm. I've attended a meeting which illustrated the additional steps on how to utilize the service with neutron. While I dont expect reproduced documentation that lives on cisco.com - it should be clear to the user what steps are required to produce a functioning setup after deploying the charm into their openstack infrastructure.

I didn't see any inherent issues with the charm code. Its fairly clean and straight forward on what the charm itself is doing.

Barring some updates to the documentation, and a review from an openstack charmer you're very close to making it into the charm store. Thanks again for the efforts to making a high quality submission to the charm store.

Thanks again for the submission. I'm going to change status of this this bug to "incomplete" and when you're ready for another review please set the status to "fix committed" or "new" and someone will be along shortly to review your work.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>