Comment 5 for bug 1229377

Revision history for this message
Jeff Pihach (hatch) wrote :

Thanks for the review Ben.

As we discussed on IRC I'm going to leave the current SQLite and MySQL database interactions intact so that the experience is as close to using the default ghost blog installation set up as possible but I will promote the warning that the information will need to be manually transferred over in the readme. Once this lands I'll follow it up with bundles which have mysql and haproxy by default which I will then suggest as the recommended way to deploy this charm.

Also discussed in IRC is that I don't need internally resolvable addresses so the xip.io is not necessary. If someone has an issue with this we can revisit it at that time.

Knitpicks

It wasn't defaulting to port 80 to keep in line with the defaults of the Ghost install but I can change that.

I can't think of a reason where changing the host from 0.0.0.0 would be desired but I figured I might as well leave the option in there in the event someone does find it useful.

I'll update the charm and re-submit shortly.