Comment 3 for bug 1199052

Greetings Jose,

Thank you for your work on this charm. I have been looking forward to this release since the postfix charm was submitted for review. I have a few notes and concerns that have been outlined below.

the charm passes charm proof, excellent!

in metadata.yaml - you define mailinglist as interface html. Why not use website or http so you can hook mailman into load balancers and reverse proxys?

During the config-changed hook execution, it fails the deployment with the following output:
PID unreadable in: /var/run/mailman/mailman.pid
[Errno 2] No such file or directory: '/var/run/mailman/mailman.pid'
Is qrunner even running?
Site list is missing: mailman
   ...fail!

barring this fix, I didn't see anything else inherently out there with the charm. You are very close to getting the mailman charm into the charm store. Thanks again for the work you've invested.

I'm going to place the status of this bug as "incomplete". When you are ready for another review simply move the status to "new" or "Fix committed" and someone will be along shortly to review your work.