Comment 10 for bug 1195736

Maarten,

Thank you for updating this charm and resubmitting it for review, and apologies for it taking so long to get the update reviewed. The updated charm looks good but for a few issues:

It seems that you moved the files into a subdirectory ("storm"), which causes it to fail to deploy. (All of the files need to be in the top level of the charm for it to work correctly.) I also noticed that you're not validating the SHA512 nor MD5 for the apache-storm-$version.zip file that's being downloaded.

With the subdirectory moved up, the charm passed proof without any warnings or errors, and I was able to deploy it according to the example configuration from the README. However, I think I might have run into the issue you mentioned in your previous comment regarding nimbus.

The first time I tried to load the page, I got a java traceback due to a connection error, and it seemed that the storm-nimbus daemon had died due to not being able to connect to the zookeeper service; I was able to get it working with "sudo storm restart" on stormmaster/0, though, so it seems like it was just a transient error. I think just adding the --respawn option to the storm-nimbus daemon line might be sufficient, but converting the init.d script to a couple of Upstart config files would probably make them quite a bit cleaner and easier to maintain.

I look forward to seeing the issues addressed so that I can add my +1 for getting this charm into the store!