Comment 9 for bug 1167363

Revision history for this message
Mark Mims (mark-mims) wrote :

This looks good.

I'd personally like to see this as one of many roles of a single postgresql charm, but this makes perfect sense as a standalone charm.

Charm proof still gripes quite a bit:

W: Metadata is missing categories.
https://bugs.launchpad.net/charms/+source/postgresql-psql/+bug/1187196

W: No icon.svg file.
https://bugs.launchpad.net/charms/+source/postgresql-psql/+bug/1187194

W: all charms should provide at least one thing
imo it's safe to ignore these given the nature of this consumer-only, 'provides-nothing' service

W: missing recommended hook start
W: missing recommended hook stop
and it doesn't actually start or stop anything, so we should ignore these.

promulgated... thanks!