Comment 6 for bug 1167363

On Tue, May 21, 2013 at 11:26 AM, Robert Ayres
<email address hidden> wrote:
> Thanks for updating, I've reviewed your new charm and have made a few
> comments below.
>
> *Consider storing pgpass files under ~ubuntu, being that the scripts are
> located here

I'm somewhat nervous about colocated charms. I would have generated
the scripts into the charm directory too except there seemed to be no
sane way to get them onto the PATH. If ~ubuntu is a better choice then
I'm happy to move them.

> *I'd remove 'README' placing everything in 'README.markdown'
>
> *~ubuntu/bin/psql-db-* scripts are badly formatted, the shebang isn't
> even the first line!
>
> *~ubuntu/bin/psql-db-*, I'd make them call psql with "$@" rather than $*

I'll fix these, next week probably.

> I'm curious as to what you're using this charm for? I think it's useful,
> but why a separate charm when this could be either part of the
> PostgreSQL charm or say a subordinate charm? I'm just wondering why
> you'd run a whole separate node for psql :)

The prime use is for automated testing of the PostgreSQL charm. I need
a simple reliable client that can be automated to interogate the
PostgreSQL cluster to ensure that things are working as expected after
charm upgrades, failover, relationship changes etc. The initial
framework and first simple test is up for review and requires the
postgresql-psql charm to be found in the store.

--
Stuart Bishop <email address hidden>