Comment 5 for bug 1167363

Revision history for this message
Robert Ayres (robert-ayres) wrote :

Thanks for updating, I've reviewed your new charm and have made a few comments below.

*Consider storing pgpass files under ~ubuntu, being that the scripts are located here

*I'd remove 'README' placing everything in 'README.markdown'

*~ubuntu/bin/psql-db-* scripts are badly formatted, the shebang isn't even the first line!

*~ubuntu/bin/psql-db-*, I'd make them call psql with "$@" rather than $*

I'm curious as to what you're using this charm for? I think it's useful, but why a separate charm when this could be either part of the PostgreSQL charm or say a subordinate charm? I'm just wondering why you'd run a whole separate node for psql :)