Comment 8 for bug 1083008

Revision history for this message
Matt Bruzek (mbruzek) wrote :

Hello Paul,

First and foremost thanks for the submission of this charm. It is available on the charm store in your personal namespace. People can download your charm using:

    charm get cs:~paulcz/charms/precise/auth-proxy

To get in the charm store requires following the current charm policy. This charm is missing some information that required by our tooling and process. Please add "categories" key in the metadata.yaml file. The valid option for this charm would be "misc". So simply adding categories: ["misc"] would resovle the metadata problem.

To address the icon warning you can either make an icon using inkscape following these instruction: https://juju.ubuntu.com/docs/authors-charm-icon.html or if there is no icon/image for this service you can grab the "juju-placeholder-a.svg" icon from our placeholder icons here: https://github.com/juju-solutions/generic-charm-icons (the convention we are using is the first letter of the charm name as the generic icon). That said I would highly recommend making a unique icon.

I also noticed that your README instructs the user to set an empty string value. This worked on older versions of juju but setting empty string values is not working on the latest juju. I opened a bug against this in juju-core that is currently working on this issue. This bug is currently affecting only one person. So if you want to add yourself to the bug it might get released faster.

https://bugs.launchpad.net/juju-core/1.20/+bug/1348829

Thanks again for your time writing this charm! Set the bug back to "new" or "fix committed" once you have fixed these issues and we will give it another review.