Comment 3 for bug 1083008
Revision history for this message
| Clint Byrum (clint-fewbar) wrote Re: [Bug 1083008] Re: new charm - auth-proxy | #3 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
79ea94a
(Get the code!)
Excerpts from Juan L. Negron's message of 2012-11-29 18:43:47 UTC:
> Hi Paul:
>
> Here is my feedback on auth-proxy:
> - install
> --- As a subordinate, you should be careful when replacing files that could also be used by the main charm. I see that you are replacing default and default-ssl which may already have been modified and used by the main charm. At a minimum, you should determine if the file has been modified before replacing it. Arbitrarily replacing such a common ( and maybe essential ) file could be dangerous.
>
The way to handle this is to not use 'juju-info' as your required
subordinate interface. Instead, require a 'local-apache' interface which
will allow the sub to talk to charms that understand it about things
like where config files are and what conflicting settings are used. This
makes sense so that other aspects of apache can be put into subordinates,
such as rewrite rules for old sites, special logging configurations,
and probably the biggest one, tuning.
juju-info is for things that wouldn't normally interfere with a primary
charm, such as syslogging or monitoring agents.