Comment 30 for bug 1866741

Reviewed: https://review.opendev.org/713291
Committed: https://git.openstack.org/cgit/openstack/charm-placement/commit/?id=72a060167fbf782bb0842c65bbed8948f165ca53
Submitter: Zuul
Branch: stable/20.02

commit 72a060167fbf782bb0842c65bbed8948f165ca53
Author: Alex Kavanagh <email address hidden>
Date: Mon Mar 16 17:02:50 2020 +0000

    Avoid multiple calls to create_ip_cert_links

    (This is a rebuild of the charm to pull in the fix that is in stable
    charms.openstack.)

    Prior to this change, the call to create_ip_cert_links was inside the
    for loop of tls objects. This caused LP Bug#1866741 where a sym link
    with the same certificate name would get overwritten with a new cert.
    This meant the last certificate of [internal, admin, public] would be
    written to all three.

    This change calls create_ip_cert_links and state sets only once. It also
    adds a warning log entry if we accidentally overwrite sym linked files in
    the future.

    Change-Id: Idd99fac8b5c48755b2ef2797deaa688cd2544281
    Partial-Bug: #1866741