Comment 28 for bug 1866741

Reviewed: https://review.opendev.org/713205
Committed: https://git.openstack.org/cgit/openstack/charms.openstack/commit/?id=8702d27254c6e73ffd383bada69ddcafd0c7f970
Submitter: Zuul
Branch: stable/20.02

commit 8702d27254c6e73ffd383bada69ddcafd0c7f970
Author: David Ames <email address hidden>
Date: Tue Mar 10 11:24:46 2020 -0700

    Avoid multiple calls to create_ip_cert_links

    Prior to this change, the call to create_ip_cert_links was inside the
    for loop of tls objects. This caused LP Bug#1866741 where a sym link
    with the same certificate name would get overwritten with a new cert.
    This meant the last certificate of [internal, admin, public] would be
    written to all three.

    This change calls create_ip_cert_links and state sets only once. It also
    adds a warning log entry if we accidentally overwrite sym linked files in
    the future.

    Change-Id: I4b36d7fd5e74ab3a894eb4a2451b5876fd777552
    Partial-Bug: #1866741
    (cherry picked from commit 72cfde8308684905363e80e4ca5db57f18573927)