Reviewed: https://review.opendev.org/c/openstack/charms.ceph/+/792720 Committed: https://opendev.org/openstack/charms.ceph/commit/626a5ce3ca868286d7341fd7e53e9e161f969ecc Submitter: "Zuul (22348)" Branch: master
commit 626a5ce3ca868286d7341fd7e53e9e161f969ecc Author: Alex Kavanagh <email address hidden> Date: Sat May 22 15:30:36 2021 +0100
Fix "Remove chrony in a container" patch with test
Unfortunately, the original patch didn't work [1]. Then a fix was applied also without a test [2]. Unfortunately, this wasn't correct either.
This patch simplifies the function, which makes it a little easier to reason about. Also a test is added to stop regressions in the future.
[1] Ie3c9c5899c1d46edd21c32868938d3290db321e7 [2] Ifef76eacd8bd837d2181ec75e406aa35f88b8b5b Closes-Bug: #1929054
Change-Id: I93f53274bc8c7e62ebb8cb7bf81ff816f4bfd98b
Reviewed: https:/ /review. opendev. org/c/openstack /charms. ceph/+/ 792720 /opendev. org/openstack/ charms. ceph/commit/ 626a5ce3ca86828 6d7341fd7e53e9e 161f969ecc
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 626a5ce3ca86828 6d7341fd7e53e9e 161f969ecc
Author: Alex Kavanagh <email address hidden>
Date: Sat May 22 15:30:36 2021 +0100
Fix "Remove chrony in a container" patch with test
Unfortunately, the original patch didn't work [1]. Then a fix was
applied also without a test [2]. Unfortunately, this wasn't correct
either.
This patch simplifies the function, which makes it a little easier to
reason about. Also a test is added to stop regressions in the future.
[1] Ie3c9c5899c1d46 edd21c32868938d 3290db321e7 7d2181ec75e406a a35f88b8b5b
[2] Ifef76eacd8bd83
Closes-Bug: #1929054
Change-Id: I93f53274bc8c7e 62ebb8cb7bf81ff 816f4bfd98b