commit 943f4f63ab256cba61ce9eceb473ed4d671f132e
Author: Peter Sabaini <email address hidden>
Date: Tue Oct 13 23:14:32 2020 +0200
Fix: nrpe queue check should check for freshness
Make the rabbitmq queue check also check if its input data file was
recently updated. This input data is created via cronjob; if that gets
stuck we might not actually be getting meaningful data.
The charm supports configuring the check interval via a full cron time
specification, so technically one could have that updated only once a
year even if this doesn't make much sense in a monitoring scenario.
Also fix a buglet in the nrpe update hook function: only deploy a
queue check if the cron job hasn't been deconfigured by setting it to
the empty string
Reviewed: https:/ /review. opendev. org/757955 /git.openstack. org/cgit/ openstack/ charm-rabbitmq- server/ commit/ ?id=943f4f63ab2 56cba61ce9eceb4 73ed4d671f132e
Committed: https:/
Submitter: Zuul
Branch: master
commit 943f4f63ab256cb a61ce9eceb473ed 4d671f132e
Author: Peter Sabaini <email address hidden>
Date: Tue Oct 13 23:14:32 2020 +0200
Fix: nrpe queue check should check for freshness
Make the rabbitmq queue check also check if its input data file was
recently updated. This input data is created via cronjob; if that gets
stuck we might not actually be getting meaningful data.
The charm supports configuring the check interval via a full cron time
specification, so technically one could have that updated only once a
year even if this doesn't make much sense in a monitoring scenario.
Also fix a buglet in the nrpe update hook function: only deploy a
queue check if the cron job hasn't been deconfigured by setting it to
the empty string
Change-Id: I60141397f39e3b 1b0274230db8d98 4934c98a08d
Closes-Bug: #1898523