Comment 1 for bug 1694377

This also seems, at least, odd to me. It looks like the rationale was that the rabbitmq-server can be upgraded to version from a different source pocket (like, 'newer' cloud archive repos, or some other ppa) by merely doing 'juju set rabbitmq-server source="cloud:..." - that will change the sources.list and run apt-get update/upgrade mantra.

However, this has a undesired side effect: apt-get update/upgrade is being run each time config-hook is run - when machine gets rebooted, when state server(s) get rebooted, or when some other charm option has been changed and it means that the operator lost control on when the packages are being upgraded.

Usually the operator wants to control when packages are being upgraded; it is highly unusual that one would get packages upgraded after machine gets rebooted.

I've also checked other openstack charms and none of them exhibit this behavior. For all of the other charms setting the 'source' or 'origin' charm option will not auto-trigger apt-get update/upgrade mantra; this seems like the correct behavior. If an operator wishes to change/upgrade his or hers packages a 'juju set' accompanied with 'juju run' or desired action should be executed.

To be consistent with other charms (at least), the commit https://github.com/openstack/charm-rabbitmq-server/commit/28067861bf8711ec1359a87feebeb534a88028a7 (which introduced this change) should be, imho, reverted.