Comment 12 for bug 1884284

Reviewed: https://review.opendev.org/749686
Committed: https://git.openstack.org/cgit/openstack/charm-hacluster/commit/?id=e02c6257ae127c86d5c5bc41045b6cd841a46fbe
Submitter: Zuul
Branch: master

commit e02c6257ae127c86d5c5bc41045b6cd841a46fbe
Author: Liam Young <email address hidden>
Date: Wed Sep 9 09:30:46 2020 +0000

    Fix adding of stonith controlled resources.

    There appears to be a window between a pacemaker remote resource
    being added and the location properties for that resource being
    added. In this window the resource is down and pacemaker may fence
    the node.

    The window is present because the charm charm currently does:

    1) Set stonith-enabled=true cluster property
    2) Add maas stonith device that controls pacemaker remote node that
       has not yet been added.
    3) Add pacemaker remote node
    4) Add pacemaker location rules.

    I think the following two fixes are needed:

    1) For initial deploys update the charm so it does not enable stonith
       until stonith resources and pacemaker remotes have been added.

    2) For scale-out do not add the new pacemaker remote stonith resource
       until the corresponding pacemaker resource has been added along
       with its location rules.

    Depends-On: Ib8a667d0d82ef3dcd4da27e62460b4f0ce32ee43
    Change-Id: I7e2f568d829f6d0bfc7859a7d0ea239203bbc490
    Closes-Bug: #1884284