The checks that keystone was performing before emitting identity
data were applicable to any Openstack api charm so the check
definitions have been moved to charmhelpers so other charms can
use them. The checks as they were are encapsulated in
`check_api_unit_ready` *1
Bug 1818113 was caused by keystone emitting identity data
as soon as the leader was ready but ignoring the state of the
peer units. This is now covered by a new check
`check_api_application_ready` which performs all the local
unit checks and then checks that all peers have reported
as ready too.
In addition `check_api_unit_ready` is now used when
setting the units workload status and `check_api_application_ready`
is used when setting the application workload status.
Reviewed: https:/ /review. opendev. org/721558 /git.openstack. org/cgit/ openstack/ charm-keystone/ commit/ ?id=53bcfd0a064 c11d90009d42f9f be61d79f963e9c
Committed: https:/
Submitter: Zuul
Branch: master
commit 53bcfd0a064c11d 90009d42f9fbe61 d79f963e9c
Author: Liam Young <email address hidden>
Date: Tue Apr 21 09:26:13 2020 +0000
Check peers before emitting identity data
The checks that keystone was performing before emitting identity api_unit_ ready` *1
data were applicable to any Openstack api charm so the check
definitions have been moved to charmhelpers so other charms can
use them. The checks as they were are encapsulated in
`check_
Bug 1818113 was caused by keystone emitting identity data api_application _ready` which performs all the local
as soon as the leader was ready but ignoring the state of the
peer units. This is now covered by a new check
`check_
unit checks and then checks that all peers have reported
as ready too.
In addition `check_ api_unit_ ready` is now used when api_application _ready`
setting the units workload status and `check_
is used when setting the application workload status.
*1 https:/ /github. com/juju/ charm-helpers/ blob/master/ charmhelpers/ contrib/ openstack/ utils.py# L2289 /github. com/juju/ charm-helpers/ blob/master/ charmhelpers/ contrib/ openstack/ utils.py# L2330
*2 https:/
Change-Id: I99830ab2c2482e 8beef1744248209 07ce96fd5d7
Closes-Bug: #1818113