Comment 53 for bug 1771662

I'd not go the "implement the perfect thing" route without strictly requiring it.

I only meant to get upstreams thoughts on it.
They don't have to accept it "that way" to consider it for us as a fix.
But suggesting it there on the old thread [1] that is dead since then would help.

I would not expect they take it as-is but who knows, and vice versa they might spot an issue doing it that way in reviewing it.

No matter what submitting it upstream would help to ensure the patch is good and to know if we need more (or not) to eventually bring it upstream.
Please CC me on that upstream submission so I can stay in the loop.

FYI: I'm out a week after today, but there is no libvirt upload in flight for cosmic. I checked the PPA [2] and found no issues with it (and it should be the same for 18.10, although I haven't tested it), so after you got a generally positive upstream reply feel free to upload to Cosmic next week if you want.
Otherwise I'll take a look when I'm back.

[1]: https://www.redhat.com/archives/libvir-list/2018-March/msg01383.html
[2]: https://launchpad.net/~dannf/+archive/ubuntu/test