Comment 46 for bug 1771662
Revision history for this message
| Christian Ehrhardt (paelzer) wrote | #46 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Nice find Dann!
There are examples of excluding some devices of that check already.
E.g. in libvirt 4.1 non-PCI devices were excluded [1]
I like your change even being only a workaround so far.
Linaro has adopted a much more aggressive temp fix [2] with more compatibility issues.
The only thing that bothers me is that if there is a fix to something else than libvirt (e.g. the cavium kernel driver) then the workaround will block the usage still.
The test on the ppa is great, but eventually I wonder if we could make this part of one of the conffiles and use like virConfGetValue
It might even default to an empty list if that is more acceptable upstream, but allow installations to mask broken devices as needed.
Unfortunately none of the existing configs is used in the scope that we'd need it, which implies it would likely be a new config file [4] that is needed.
There is a lot of the usual overhead (check paths, permissions, ...) to be added just for that, but maybe it would make the hack upstreamable.
Hmm, OTOH maybe it would be over-engineering and we just use the simple change you suggested which would declare this network card not supporting switchdev offloads (even if fixed int he kernel driver, it is unlikely to reach Bionic trivially other than maybe HWE kernels)
But for now lets see what result the test on your ppa delivers
[1]: https:/
[2]: https:/
[3]: https:/
[4]: https:/