Comment 21 for bug 2002154

Reviewed: https://review.opendev.org/c/openstack/charm-nova-cloud-controller/+/881443
Committed: https://opendev.org/openstack/charm-nova-cloud-controller/commit/323923ed20d342b90997d3e5e9531932782f0a12
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 323923ed20d342b90997d3e5e9531932782f0a12
Author: Felipe Reyes <email address hidden>
Date: Fri Apr 21 19:36:01 2023 -0400

    Update nova relations data on ha-relation-changed

    When taking the nova-cloud-controller from single unit to full HA by
    increasing the number of units from 1 to 3 and relating it to hacluster,
    the data set on the cloud-compute relation is not updated, because the
    update_nova_relation() function is only called on
    cloud-compute-relation-joined and config-changed, none of these hooks
    are executed when scaling out the application.

    This patch introduces a call to update_nova_relation() on
    ha-relation-changed.

    Test case on an environment deployed with a single unit of
    nova-cloud-controller:

        export NOVA_CC_VIP=10.0.0.11
        juju config nova-cloud-controller vip=$NOVA_CC_VIP
        juju deploy --series jammy --channel 2.4/stable hacluster \
            nova-cloud-controller-hacluster
        juju add-unit -n 2 nova-cloud-controller
        juju deploy --series jammy memcached
        juju add-relation memcached nova-cloud-controller
        juju add-relation nova-cloud-controller nova-cloud-controller-hacluster

    Change-Id: Ib08bf9b6e1ce2b69be4d99ffe0726b59d81f4bc9
    Closes-Bug: #2002154