Comment 19 for bug 2007919

Revision history for this message
Robie Basak (racb) wrote :

Thanks.

I looked at the specific changes being made by upstream in this microrelease, and have some concerns. I found them broken down by commit here: https://opendev.org/openstack/ovsdbapp/commits/branch/stable/yoga

https://opendev.org/openstack/ovsdbapp/commit/ab3e0cb0d0865417efbf103f44954573a5ba92ac - this seems like a deliberate change in behaviour. But it doesn't come with any tests, and there's no explanation as to why it's needed in a stable release. Is this even a bugfix? What if the retrying behaviour *is* working for some user? Won't dropping that behaviour regress them?

https://opendev.org/openstack/ovsdbapp/commit/92cbba4481a7c7acedf24d8250fc7cf4be6b46d7 seems OK as a bugfix, but doesn't come with a test.

https://opendev.org/openstack/ovsdbapp/commit/315c8096c9bb3ad6d09e3b2f09bc1c128bc35497 seems good as a bugfix, and refers to bug 1988457 as what it is fixing, but doesn't come with a test.

https://opendev.org/openstack/ovsdbapp/commit/a69430a967bfa1096b9258a8445b617b9e122a22 doesn't come with a test.

https://opendev.org/openstack/ovsdbapp/commit/de473cea9defe04a6f904fa63a8cf49746534916 fixes a regression caused by a change in OVS, and does come with a test - great!

Conclusion

It doesn't seem like upstream microrelease updates come with enough testing to land them for Ubuntu users in stable releases without further manual testing. The upstream ab3e0cb commit is also concerning as it is a deliberate change in behaviour.

NACK for an Ubuntu SRU based on the upstream microrelease exception. Please justify and test each change you need individually instead.