Comment 4 for bug 1839666

The latest version is looking good. Lots of nice changes.

I did come across a couple bugs that I mentioned above. Very simple to change.

I don't use this charm for Sharding purposes but I don't think it can without these changes, and potentially the --shardsvr flag mentioned above.

Here are my notes:

BUG: in enable_mongos function, when calling disable_mongos (line 1081), config_data['mongos_port'] is not passed as a parameter and should be.

BUG: looks like the wrong parameters are passed to enable_configsvr in the config_changed function, line 1372):
    * CURRENTLY: enable_configsvr(config_data["config_server_port"])
    * SHOULD BE: enable_configsvr(config_data)
    * config_data is all that is requested by enable_configsvr

BUG: Similar to the one above, when calling enable_mongos in config_changed function (line 1388):
    * CURRENTLY: enable_mongos(config_data["mongos_port"])
    * SHOULD BE: enable_mongos(config_data)
    * config_data is all that is requested by enable_mongos