Comment 5 for bug 1989362

Revision history for this message
George Kraft (cynerva) wrote :

Traceback from the occurrence in comment #4: https://paste.ubuntu.com/p/nX3Jm85qvB/

OK, so once again: same root cause, same presenting symptom, different code path. In this case, the InternalServerError was caught properly in the _client function and then re-raised as VaultNotReady. The problem now is that kubernetes-control-plane didn't catch the VaultNotReady exception.

It looks like both the generate_encryption_key handler[1] and the _write_encryption_config function[2] (or its caller) may need to be updated to catch VaultNotReady.

[1]: https://github.com/charmed-kubernetes/charm-kubernetes-control-plane/blob/7de2ed17e09c1709c49d72572eab299c5a64fcf0/reactive/kubernetes_control_plane.py#L3229
[2]: https://github.com/charmed-kubernetes/charm-kubernetes-control-plane/blob/7de2ed17e09c1709c49d72572eab299c5a64fcf0/reactive/kubernetes_control_plane.py#L3243