Comment 29 for bug 1818113

Reviewed: https://review.opendev.org/721558
Committed: https://git.openstack.org/cgit/openstack/charm-keystone/commit/?id=53bcfd0a064c11d90009d42f9fbe61d79f963e9c
Submitter: Zuul
Branch: master

commit 53bcfd0a064c11d90009d42f9fbe61d79f963e9c
Author: Liam Young <email address hidden>
Date: Tue Apr 21 09:26:13 2020 +0000

    Check peers before emitting identity data

    The checks that keystone was performing before emitting identity
    data were applicable to any Openstack api charm so the check
    definitions have been moved to charmhelpers so other charms can
    use them. The checks as they were are encapsulated in
    `check_api_unit_ready` *1

    Bug 1818113 was caused by keystone emitting identity data
    as soon as the leader was ready but ignoring the state of the
    peer units. This is now covered by a new check
    `check_api_application_ready` which performs all the local
    unit checks and then checks that all peers have reported
    as ready too.

    In addition `check_api_unit_ready` is now used when
    setting the units workload status and `check_api_application_ready`
    is used when setting the application workload status.

    *1 https://github.com/juju/charm-helpers/blob/master/charmhelpers/contrib/openstack/utils.py#L2289
    *2 https://github.com/juju/charm-helpers/blob/master/charmhelpers/contrib/openstack/utils.py#L2330

    Change-Id: I99830ab2c2482e8beef174424820907ce96fd5d7
    Closes-Bug: #1818113