Comment 11 for bug 1777714

Reviewed: https://review.opendev.org/658394
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=a51efaf640b4138e3fd930fe6521ab6905bc2e0a
Submitter: Zuul
Branch: master

commit a51efaf640b4138e3fd930fe6521ab6905bc2e0a
Author: Rodrigo Barbieri <email address hidden>
Date: Fri May 10 11:38:53 2019 -0300

    Propagate vendor_data from nova-cloud-controller

    When using DVR and L3HA neutron deployment options,
    Nova API Metadata requests are served from compute nodes,
    instead of from neutron-gateway nodes.

    This change allows nova-cloud-controller to send vendor_data
    configuration values to nova-compute charm relation so it
    can write to nova-compute's nova.conf appropriately.

    Replaced the existing context logic with inheritance
    from a new context created in charm-helpers, so the
    logic can be shared across several charms that write
    vendor metadata to nova.conf and vendor_data.json.

    Also, small fix in the vendor-data and vendor-data-url
    descriptions, where it was incorrectly stating that such
    configuration would be effective in nova-cloud-controller
    on Queens release.

    The values set in vendor-data and vendor-data-url config
    options will always be propagated to nova-compute regardless
    of the OpenStack release. Those values will continue to only
    be effective in nova-cloud-controller nodes on Rocky release
    or later.

    Included sync of charm-helpers code in order to inherit
    the refactored vendor metadata contexts.

    Change-Id: If8373fc6b2d04dbc29ed07896d385ac920cae3f4
    Depends-On: I0c79e1bfac9fbe7009a7e862ad010cfa2de8cfda
    Closes-Bug: #1777714