Comment 20 for bug 1654116

Revision history for this message
John A Meinel (jameinel) wrote :

I'll note that 'peer_store' isn't safe to directly call, but looking at the traceback of the original description it is line ~217 of hooks/amqp-relation-changed which looks to be:
    # If this node is the elected leader then share our secret with other nodes
    if is_elected_leader('grp_ceilometer_vips'):
        peer_store('shared_secret', get_shared_secret())

And 'is_elected_leader' is just a call to 'is-leader' with a bunch of other stuff if 'is-leader' doesn't exist.

So I can't see anything functionally wrong with the code. It does, indeed, appear to be checking before it actually does the work.