Hi Tim,
As I can see containerd bug #1443 is now fixed. However, I think there is also a bug in charm template[1]:
``` [plugins.cri.registry] [plugins.cri.registry.mirrors] [plugins.cri.registry.mirrors."docker.io"] endpoint = ["https://registry-1.docker.io"] {% if custom_registries %} [plugins.cri.registry.auths] {% for registry in custom_registries %} {% if registry.username and registry.password %} [plugins.cri.registry.auths."{{ registry.url }}"] username = "{{ registry.username }}" password = "{{ registry.password }}" {% endif %} {% endfor %} [plugins.cri.registry.configs] {% for registry in custom_registries %} {% if registry.ca or registry.cert or registry.key or registry.insecure_skip_verify %} [plugins.cri.registry.configs."{{ registry.url }}".tls] ca_file = "{{ registry.ca if registry.ca else '' }}" cert_file = "{{ registry.cert if registry.cert else '' }}" key_file = "{{ registry.key if registry.key else '' }}" insecure_skip_verify = {{ "true" if registry.insecure_skip_verify else "false" }} {% endif %} {% endfor %} {% ```
According to doc[2], we expect config like this for new registry:
[plugins.cri.registry] [plugins.cri.registry.mirrors] ... [plugins.cri.registry.mirrors."34.235.169.214:5000"] endpoint = ["http://34.235.169.214:5000"] ...
However, that is not rendered by template at all.
[0]: https://jaas.ai/u/containers/containerd#charm-config-custom_registries [1]: https://github.com/charmed-kubernetes/charm-containerd/blob/a35726e8f908ba8fef5fc9000c0e5ee850ac9ae0/templates/config.toml#L63 [2]: https://github.com/containerd/cri/blob/master/docs/registry.md#configure-registry-endpoint
Hi Tim,
As I can see containerd bug #1443 is now fixed.
However, I think there is also a bug in charm template[1]:
``` cri.registry] plugins. cri.registry. mirrors]
[plugins. cri.registry. mirrors. "docker. io"] /registry- 1.docker. io"] plugins. cri.registry. auths]
[plugins. cri.registry. auths." {{ registry.url }}"] plugins. cri.registry. configs] insecure_ skip_verify %}
[plugins. cri.registry. configs. "{{ registry.url }}".tls]
insecure_ skip_verify = {{ "true" if registry. insecure_ skip_verify else "false" }}
[plugins.
[
endpoint = ["https:/
{% if custom_registries %}
[
{% for registry in custom_registries %}
{% if registry.username and registry.password %}
username = "{{ registry.username }}"
password = "{{ registry.password }}"
{% endif %}
{% endfor %}
[
{% for registry in custom_registries %}
{% if registry.ca or registry.cert or registry.key or registry.
ca_file = "{{ registry.ca if registry.ca else '' }}"
cert_file = "{{ registry.cert if registry.cert else '' }}"
key_file = "{{ registry.key if registry.key else '' }}"
{% endif %}
{% endfor %}
{%
```
According to doc[2], we expect config like this for new registry:
[plugins. cri.registry] plugins. cri.registry. mirrors]
[plugins. cri.registry. mirrors. "34.235. 169.214: 5000"] 34.235. 169.214: 5000"]
[
...
endpoint = ["http://
...
However, that is not rendered by template at all.
[0]: https:/ /jaas.ai/ u/containers/ containerd# charm-config- custom_ registries /github. com/charmed- kubernetes/ charm-container d/blob/ a35726e8f908ba8 fef5fc9000c0e5e e850ac9ae0/ templates/ config. toml#L63 /github. com/containerd/ cri/blob/ master/ docs/registry. md#configure- registry- endpoint
[1]: https:/
[2]: https:/