Comment 2 for bug 2054398

Hi @ajkavanagh

According to the code [1], it will delete all cinder services if the host is not 'cinder' or 'cinder@cinder-ceph'.
But I've seen 2 exceptions from user's environment.

1. In some deployments, cinder-scheduler service's host is hostname, e.g. juju-xxx-lxd-xxx, and not 'cinder'. In this case the cinder-scheduler service will be removed. Although it can be created again, this is not necessary.
| cinder-scheduler | juju-fa8549-4-lxd-1 | nova | enabled | up | 2024-02-01T07:10:58.000000 |
| cinder-scheduler | juju-fa8549-8-lxd-1 | nova | enabled | up | 2024-02-01T07:10:59.000000 |
| cinder-scheduler | juju-fa8549-6-lxd-1 | nova | enabled | up | 2024-02-01T07:10:59.000000 |

2. Some users use other storage backends, e.g. purestorage, and not ceph. Those services will also be removed.
| cinder-volume | cinder-volume@cinder-purestorage | nova | enabled | up | 2024-02-01T07:11:02.000000 |
When this is removed, if the user has multiple cinder units, several cinder-volume services will be created for purestorage. This is not right, since only one is required.

I think this action shouldn't remove a cinder service if it is up. The check on 'host' is not quite right since it doesn't consider those who use a backend which is not ceph.

Thanks!

[1] https://opendev.org/openstack/charm-cinder/src/branch/master/actions/cinder_manage.py#L123