Comment 131 for bug 1990062

Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

@wilkmarcin

The bug in designate is different to this one. On the stable/yoga branch the designate charm has:

class DesignateCharmQueens(DesignateCharm):

    # This charms support Queens and onward
    release = 'queens'

    ...

    def run_upgrade(self, interfaces_list=None):
        """Upgrade OpenStack if an upgrade is available and action-managed
           upgrades is not enabled.
        :param interfaces_list: List of instances of interface classes
        :returns: None
        """
        super(DesignateCharmQueens, self).run_upgrade(
            interfaces_list=interfaces_list)
        memcached = relations.endpoint_from_flag(
            'coordinator-memcached.available')
        memcached.request_restart()

However, the action calls run_upgrade(...) as:

def openstack_upgrade_action(*args):
    """Run the openstack-upgrade action."""
    with charms_openstack.charm.provide_charm_instance() as charm_instance:
        charm_instance.run_upgrade(upgrade_openstack=True)
        charm_instance._assess_status()

i.e. with the "upgrade_openstack=True" param, and the charms.openstack lib also has that parameter.

This is an actual bug in the designate charm not being updated to support the "upgrade_openstack" optional param but it existing in the lib. As such it's a new/different bug.