Comment 10 for bug 1393438

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

Right, what you wrote above I totally agree with, but it's not how it's currently implemented, and we were not aware this is how it was supposed to work. We just got a new boolean setting and we dealt with it as with any other.

Now, to rectify this untranslatable string somewhat quickly, I propose the setting comes of "location" instead of "boolean" type, which we'd then render as we please, including the currently-untranslatable string.

Long-term, IMO we should make use of the trusted location helper, which would take care of ensuring the scope in question is allowed to get location data (and of what accuracy), the dash would either act as a proxy, as it does today, or the scope will request data from the location service directly, but we'd then need a way to link the scope process to a surface on which to open the location trust store dialog. That would be useful for other use cases as well (payments, accounts etc.), so might be a nobler goal.