Canonical System Image

URL Dispatcher Should Prompt on Bad URL

Bug #1370008 reported by errors.ubuntu.com bug bridge
56
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Confirmed
Medium
Bill Filler
Canonical System Image backlog
url-dispatcher (Ubuntu)
Fix Released
High
Ted Gould

Bug Description

The Ubuntu Error Tracker has been receiving reports about a problem regarding gallery-app. This problem was most recently seen with version 13.10.0+14.10.20140908.1-0ubuntu1, the problem page at https://errors.ubuntu.com/problem/b1f16000af092461aeb85b5c7edfd3dc3f1271c8 contains more details.

<https://wiki.ubuntu.com/URLDispatcher#Unsupported_URLs>: "Whenever the URL dispatcher is called on to open an address of a protocol that it does not understand (url-dispatcher-bad-url), it should open an alert with the title “Unrecognized Address”, text of the form ‘Ubuntu can’t open addresses of type “{protocol:}”.’, and an “OK” button. To prevent denial of UI service, however, the alert should not open if it has already opened more than three times in the past minute."

See original description
Tags: utopic

Related branches

lp:~ted/url-dispatcher/bad-url-prompt
Charles Kerr (community): Approve
unity-api-1-bot: Approve (continuous-integration)
Diff: 740 lines (+352/-72)
24 files modified
CMakeLists.txt (+1/-0)
data/CMakeLists.txt (+10/-0)
data/bad-url.qml (+42/-0)
debian/apparmor/url-dispatcher-bad-url-helper (+15/-0)
debian/control (+4/-0)
debian/rules (+1/-0)
debian/url-dispatcher.install (+3/-0)
po/CMakeLists.txt (+39/-0)
po/POTFILES.in (+1/-0)
po/genpotfiles.sh (+6/-0)
service/CMakeLists.txt (+5/-12)
service/bad-url/CMakeLists.txt (+14/-0)
service/bad-url/exec-tool.c (+42/-0)
service/dispatcher.c (+4/-0)
service/overlay-tracker-iface.h (+1/-0)
service/overlay-tracker-mir.cpp (+69/-39)
service/overlay-tracker-mir.h (+22/-8)
service/overlay-tracker.cpp (+9/-0)
service/overlay-tracker.h (+1/-0)
service/url-overlay/CMakeLists.txt (+14/-0)
tests/dispatcher-test.cc (+1/-0)
tests/overlay-tracker-mock.h (+6/-0)
tests/overlay-tracker-test.cpp (+41/-12)
tests/test-config.h.in (+1/-1)
lp:~ci-train-bot/url-dispatcher/url-dispatcher-ubuntu-yakkety-1886
lp:~ci-train-bot/url-dispatcher/url-dispatcher-ubuntu-zesty-1886
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gallery-app (Ubuntu):
status: New → Confirmed
Alberto Salvia Novella (es20490446e)
Changed in gallery-app (Ubuntu):
importance: Undecided → High
Revision history for this message
Bill Filler (bfiller) wrote :

this appears to be a webbrowser-app issue not a gallery issue, please take a look

Changed in webbrowser-app (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
importance: Undecided → High
Revision history for this message
Bill Filler (bfiller) wrote :

Seems to be 1165 occurrances of this crash according to:
https://errors.ubuntu.com/?channel_name=ubuntu-touch/stable/bq-aquaris.en&device_name=krillin&period=week&pkg_arch=armhf

Revision history for this message
Olivier Tilloy (osomon) wrote :

This is not a crash, it’s a recoverable problem. It seems to happen when trying to open market:// URLs in the browser (from pages that incorrectly assume that they are running on an android device).

I can easily reproduce the issue by opening a test page in the browser that contains this code:

  <html>
   <body>
    <a href="market://details?id=com.google.android.voicesearch">click me</a>
   </body>
  </html>

When clicking this link, I’m seeing the following error in the browser’s log:

  ** (process:14120): WARNING **: Unable to dispatch url 'market://details?id=com.google.android.voicesearch':GDBus.Error:com.canonical.URLDispatcher.BadURL: URL 'market://details?id=com.google.android.voicesearch' is not handleable by the URL Dispatcher

We could probably have a default application that registers as a handler for this type of URLs and informs the user that android applications are not compatible with Ubuntu (adding an ubuntu-ux task to get input from the design team).

Changed in gallery-app (Ubuntu):
status: Confirmed → Invalid
Changed in webbrowser-app (Ubuntu):
status: New → Confirmed
Magdalena Mirowicz (magdalena-mirowicz)
Changed in ubuntu-ux:
assignee: nobody → Matthew Paul Thomas (mpt)
status: New → Triaged
importance: Undecided → High
Revision history for this message
Stuart Langridge (sil) wrote :

In general there should probably be fallback handling in the URL dispatcher for all unknown URL schemata, I think? (Although having a dedicated handler for market: URLs may also be useful.)

Matthew Paul Thomas (mpt)
Changed in ubuntu-ux:
status: Triaged → In Progress
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Specification updated. <https://wiki.ubuntu.com/URLDispatcher?action=diff&rev2=10&rev1=9>

Changed in ubuntu-ux:
status: In Progress → Fix Committed
description: updated
Olivier Tilloy (osomon)
affects: webbrowser-app (Ubuntu) → url-dispatcher (Ubuntu)
Changed in url-dispatcher (Ubuntu):
assignee: Olivier Tilloy (osomon) → nobody
Ted Gould (ted)
summary: - url-dispatcher-bad-url
+ URL Dispatcher Should Prompt on Bad URL
Revision history for this message
Bill Filler (bfiller) wrote :

This is needed for https://bugs.launchpad.net/ubuntu/+source/address-book-app/+bug/1470309

Changed in canonical-devices-system-image:
importance: Undecided → High
Jean-Baptiste Lallement (jibel)
no longer affects: gallery-app (Ubuntu)
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: none → backlog
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Can we find someone to work on this?

Changed in canonical-devices-system-image:
assignee: nobody → Bill Filler (bfiller)
status: New → Confirmed
Bill Filler (bfiller)
Changed in canonical-devices-system-image:
importance: High → Medium
Matthew Paul Thomas (mpt)
Changed in url-dispatcher (Ubuntu):
assignee: nobody → Ted Gould (ted)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package url-dispatcher - 0.1+17.04.20161107-0ubuntu1

---------------
url-dispatcher (0.1+17.04.20161107-0ubuntu1) zesty; urgency=medium

  [ Florian Boucault ]
  * Crossbuilding Fixes

  [ Larry Price ]
  * App ID should allow package names with dots. (LP: #1591342) (LP: #1606498)

  [ Ted Gould ]
  * Check versions of appid:// urls to reduce the number of invalid appids
    we send to UAL (LP: #1352656)
  * Scope testing for the scope:// URL and overlays that should be over
    the dash
  * Protect the dash from getting NULL urls (LP: #1476257)
  * Make sure URL Overlays are shutdown on exit
  * Remove the wildcard that is confusing the update script (LP: #1461496)
  * Not using a message that isn't set properly (LP: #1608009)
  * Fixing tests to adjust for UAL changes
  * Add a small GUI helper tool for testing
  * Show error dialog over apps that use Bad URLs (LP: #1370008)

 -- Ted Gould <email address hidden> Mon, 07 Nov 2016 16:33:15 +0000

Changed in url-dispatcher (Ubuntu):
status: Confirmed → Fix Released
Matthew Paul Thomas (mpt)
no longer affects: ubuntu-ux
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.