Comment 42 for bug 885027

Revision history for this message
Schwern (schwern) wrote :

FWIW I didn't know anything about calibre before reading this. I read this because it was handed to me as an example of how not to handle a bug report. As I read through it, and the argument about whether having an application that lets anyone mount anything anywhere, a realization slowly dawned on me...

This is not a disk utility.

This is an ebook reader!

As far as the user knows, this is not "a program designed to let an unprivileged user mount/unmount/eject anything he wants", it's a program designed to read ebooks. Mounting disks is a minor convenience function. As such, most users will have no idea they've just installed a security hole so that the reader can do the equivalent of putting the book away for me. Not worth it.

@ravomavain is absolutely right, let users mount their own disks using the OS' own utilities. Every OS has user friendly ways to do that (if not, the user has problems which should not be the responsibility of an ebook reader to fix). Every other application seems to do fine without it's own mount function. If you can't do it securely, and it's not the primary function of your application, don't do it at all! I know you're trying to help, but really... that's ok. I can mount a disk. Thanks.