[Enhancement] Add warning pop-up when deleting custom highlight style

Bug #1988443 reported by Sia
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released

Bug Description

A pop-up in the e-book viewer after clicking "Remove style" in the highlight sub-menu would be great, asking if you're really sure you want to delete the style permanently. (Basically the same dialogue box as when deleting individual highlights.)

Background: When adding custom highlight colors, they get added to the left of the five existing standard colors – dangerously close to the "Remove style" button. Accidental misclicks have happened to me more than once, and since styles are on a "per installation" basis, I guess those highlights and styles are now gone from all my other documents?

Highlight styles working across different installations would be really nice; but a security pop-up would help a lot with accidental deletions.

Sia (redblackblu)
summary: - [Enhancement] Verification pop-up when deleting custom highlight
- category
+ [Enhancement] Add warning pop-up when deleting custom highlight style
Revision history for this message
Kovid Goyal (kovid) wrote :

removing a highlight style doesn't remove highlights. It just means you
cant create a new highlight using that style. Highlights you create in a
book (assuming the book is in EPUB format) are embedded in the book
along with the style definitions used for them. So they should continue
to work, regardless.

That said, I am happy to add a confirmation popup for this.

Revision history for this message
Kovid Goyal (kovid) wrote : Fixed in master

Fixed in branch master. The fix will be in the next release. calibre is usually released every alternate Friday.

 status fixreleased

Changed in calibre:
status: New → Fix Released
Revision history for this message
Sia (redblackblu) wrote :

Thanks so much for this info and the quick fix!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.