Aaron Bentley wrote:
> This approach makes it *harder* to fix bug 296125, because if any plugin
> can supply shelf_ui.diff_writer, there's no way to know whether it
> produces colourized output.
>
Why not change the DiffWriter interface to include:
"allow_colored=True/False".
Or alternatively, have the disable code just unilaterally disable the
non-native diff_writer. For the common case that a plugin is providing
colordiff, then it will have disabled coloring. For other cases, we
don't have to provide another option to disable whatever wackyness that
plugin provides.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Aaron Bentley wrote: diff_writer, there's no way to know whether it
> This approach makes it *harder* to fix bug 296125, because if any plugin
> can supply shelf_ui.
> produces colourized output.
>
Why not change the DiffWriter interface to include: colored= True/False" .
"allow_
Or alternatively, have the disable code just unilaterally disable the
non-native diff_writer. For the common case that a plugin is providing
colordiff, then it will have disabled coloring. For other cases, we
don't have to provide another option to disable whatever wackyness that
plugin provides.
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org
aKYsACgkQJdeBCY SNAAPWLACgwKB91 RlhfkkEpHGGM2xq VD8I fmmP60CGcAjF8BO lY
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkk
UFkAniSUumjroB0
=WJAK
-----END PGP SIGNATURE-----