Comment 5 for bug 90819

Revision history for this message
John A Meinel (jameinel) wrote :

This seems to me like it means all callers of _walkdirs will now need to check if it is really a directory first, before they call walkdirs. Which means they are doing the same work, just now it has to be done by every caller, rather than doing it inside one function.

The big reason (in my head) is that walkdirs is the one that touches the disk, and most callers don't.

If they already knew whether it was a file or directory (for some reason) it would be different. But all they can really know is whether they *expect* it to be a file or directory.