Comment 18 for bug 850303

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 850303] Re: UnboundLocalError 'changed' in _dirstate_helpers_pyx _loop_one_block at initial commit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 9/17/2011 6:24 PM, pgnet wrote:
> since I hadn't reported yet, building 2.4.1 release tarballt,
>
> cd /srv/www/site03 ... bzr commit -m "test"bzr Committed revision
> 1.
>
> so far, it's just the 2.4-dev branch that's got issues. the trunk
> branch, and the 2.4.1 release tarball are ok.
>

The release tarball should come with pre-generated .c files, generated
with something that isn't cython 0.15.

It is a known issue that cython 0.15 changed how variables were
initialized. Previously, all variables were default initialized to
0/NULL/None (as appropriate). They changed it to stop doing so, which
means our code needs to be audited to put those back in.

If you compile with Cython 0.15+, it should give you warnings about
non-initialized variables. I just haven't had the time to look into
all of them. Unfortunately, older versions of pyrex don't support:

cdef object var = None

So you have to do:

cdef object var
...
var = None

To be compatible across the supported versions of pyrex + cython.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk53QPYACgkQJdeBCYSNAANwqQCfY++jqeRUNV42M9ainLmxLncT
+qAAn3bD54dCc4HOCaBnH6bCVWBYJdKv
=o9Ym
-----END PGP SIGNATURE-----