Comment 10 for bug 84659
Revision history for this message
| Martin Pool (mbp) wrote Re: [Bug 84659] Re: "serve --allow-writes" allows more than you might think | #10 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
2009/7/20 Danny van Heumen <email address hidden>:
> Here is a patch that displays a warning (using 'note') when --allow-
> writes is used without --inet.
>
> ** Attachment added: "Patch that shows a warning (note) as suggested by Martin."
> http://
Thanks, that looks good Danny, with a few tweaks:
* The string should be wrapped as it makes the line too long.
* The indenting should be 4 spaces
* You should use the trace.warning function not note
* Ideally there would also be a test for it, along the lines of those
already in blackbox.test_serve
Could you please see about pushing a branch containing your fix to
Launchpad and then propose it for merging into trunk, then we can do a
proper review:
When this is merged it should be mentioned in NEWS as closing this bug.
--
Martin <http://