Comment 4 for bug 842223

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 842223] Re: Change to tilde escaping causes test failures

On 06/09/11 02:15, Martin [gz] wrote:
>> Please note that the issue that was pointed out by the reviewer is
>> already fixed in bzr.dev, and is different from what you're pointing out
>> here. That was about displaying "locations", which is different from the
>> representation we use internally anyway.
> I put that in the bug report not because I thought anyone had dropped
> the ball, just that it was relevant that the change was deliberate and
> not an oversight.
But it wasn't a deliberate decision to start escaping tildes. The
decision was about normalizing URLs. Various bits of the code (in
particular Transport._unsplit_url) have been quoting tildes forever.

>> rfc1738 considers tilde one of the unsafe characters and says that all
>> unsafe characters must always be encoded within a URL.
>> (page 30)
> And in rfc3986 it's an unreserved character, hence the endless confusion
> over tildes in urls. :)
Ah, thanks for that pointer. I guess I should get with the times and
stop pretending it's still 1994 :)

Cheers,

Jelmer