Comment 9 for bug 832061

Revision history for this message
Vincent Ladeuil (vila) wrote :

>>>>> "]" == John A Meinel writes:

<snip/>

    ]> So *if* the user sets "bzr.groupcompress.max_bytes_to_index" in
    ]> bazaar.conf, it supersedes the DEFAULT value. (I don't think we need to
    ]> add a configuration to set the DEFAULT on top of being able to set the
    ]> actual value, do you?)

Of course not, this just need to me migrated and is not the kind of
constant I'm after here, but thanks for the precisions, as I said, this
was a quick grepping.

<snip/>

    ]> So again the *DEFAULT* is a constant, but the actual value used is
    ]> configurable with "add.maximum_file_size".

Same remark.

    ]> Yes, these could

should and will before *this* bug can be fixed.

    ]> be rewritten to use the new config syntax. However, they are
    ]> *already* configurable. So I don't understand whether this bug
    ]> applies or not.

Not to these specific ones then. That why I asked for others, if they
aren't any, there is nothing left to fix by this bug.

    ]> I don't think the locking stuff needs to be configurable. We
    ]> could, but I think you're far of in diminishing returns at that
    ]> point. (We've had the same value for ~3-5 years now.)

Well, consider the issue we encountered a couple of times with mounted
file systems on windows where we couldn't get enough data from the
user(s) able to reproduce the issue. IIRC, you and Martin gives quite
precise guidance about which code should be changed to acquire the
data. Despite your efforts, we're still waiting for data.

My point here is that if the infrastructure is in place we just have to
ask for a command to be executed, no code to write, no code to install.

Is there something wrong with that ?

I don't expect all such cases to be covered, but everywhere we decided
to define a constant, we already considered that some other value(s)
*may* potentially be useful (right ?), this bug aims at making them
reachable by a simple command. Nothing more.

Hence my previous question: where are the others ? If there is none
left, fine, let's close the bug, we can even close it now and re-open it
if needed.