Comment 6 for bug 832061

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/24/2011 07:09 PM, Vincent Ladeuil wrote:
> I've discussed it with Martin, the disagreement was two-fold:
>
> - he felt the bug was too vague,
>
> - I felt setting the importance to low wasn't the right way to
> convey that the priority is low (which I agree with, I don't
> intend to fix it until the migration to the new design is
> completed, including addressing the performance issue)
>
> I answered his concern about vagueness by explaining that I think
> there are ~10 at worst 20 such constants and that I don't know
> them all.
>
> Here are the ones I can find after a quick grepping:
>
> bzrlib.workingtree.worth_saving_limit

^- This is configurable. See bzrlib.workingtree_4._worth_saving_limit

> bzrlib.groupcompress.BATCH_SIZE
> bzrlib.groupcompress.GroupCompressVersionedFiles._DEFAULT_MAX_BYTES_TO_INDEX

^- Similarly:
 bzrlib.groupcompress._LazyGroupContentManager._get_compressor_settings

> bzrlib.lockdir._DEFAULT_TIMEOUT_SECONDS
> bzrlib.lockdir.__DEFAULT_POLL_SECONDS
> bzrlib.add._DEFAULT_MAX_FILE_SIZE

Similarly bzrlib.add.AddWithSkipLargeAction.skip_file

>
> I'm sure you know more, feel free to add them (we have time to
> list them before this bug is fixed anyway).
>

Most are already configurable when we felt it would be useful. We just
didn't have the new syntax to be able to do so.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5WVQ8ACgkQJdeBCYSNAAMCxQCeLjf68xWHJ4TBTW6mF38v29uN
OykAoMu75ZGuXai9902sX0ye1VxbAzlm
=y7cO
-----END PGP SIGNATURE-----