Bazaar

  1. Bug #796582
  2. Comment #5

Comment 5 for bug 796582

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 796582] Re: committing with -x incorrectly declares the commit pointless

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...
> (As an aside: it's a bit weird that the commit builder appears to be two
> different kinds of objects in one; the delta-based builder and the
> whole-inventory-based builder; if configured in the latter mode then
> AIUI methods like record_delete are not available. Wouldn't two
> separate classes be clearer? They could still share much of the same
> code, of course, e.g. via a base class.)

Simply another class doesn't work very well because CommitBuilder is
specific to the Repository implementation.

I think we generally just want to get rid of the whole-inventory-builder
we just need to implement -x on a delta stream.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk4BBvkACgkQJdeBCYSNAANDTQCfRCcPxEwh5A0yAGDAUenYp4EG
cbgAoIkQ2YXTi0lLT03jHT2KmB6yMZU5
=zxxD
-----END PGP SIGNATURE-----