Comment 13 for bug 795024

Revision history for this message
Wouter van Heyst (larstiq) wrote : Re: [Bug 795024] Re: Always remember push target

On Fri, Jun 10, 2011 at 00:20:28 -0000, Martin Pool wrote:
> Martin
>
> I think automatically remembering the first one used is problematic,
> because the user might not associate that action with it being saved,
> or have an intention to save it then.

Right, similar to merge setting submit_location I guess. As it matches
my workflow I happen to associate/intend it doing that, but then I'm
familiar with the current behaviour.

Do you mean push shouldn't be remembering at all, or it should change
its behaviour from "remember first, don't change unless asked" to
"always save last specified location"?

For the former, I can probably learn to specify --remember on the first
push with some grumbling.

But for the latter, what happens if you say `bzr push :parent/:submit`?
Will the push location be overwritten in that case too? That doesn't
seem a good idea me, nevermind me not being convinced it is the more
common case.

> > When using the remembered location we say "Using saved push location: ...",
> > but nothing seems to be printed when pusing to another location (new or
> > not).  Perhaps it might sense to say
> >
> >    "Not using saved push location, but instead: ..."
>
> But if you specified a different location, wouldn't you know you
> specified it?

Ah hmm, yes. I was trying to deal with Olaf's confusion that his last
push didn't autosave.

    "Not saving specified location but retaining: ..." ?

which would be moot when push no longer saves on first use but only when
--remember is specified.

Wouter van Heyst