John A Meinel пишет:
> fair enough. So the question becomes, what is more useful to you,
> Alexander. osutils.terminal_encoding() or get_user_encoding()
I think the right solution is to use get_user_encoding()
because on Windows it equivalent to system default ANSI encoding.
If people don't satisfied with this encoding they *always*
can switch encoding of dos terminal with chcp command.
I use this command when I want to see in dos terminal
a diff for my non-ascii files.
>
> I realize you may not use 'bzr annotate' much. I'm just trying to figure
> out if 'terminal_encoding()' is going to be better because people
> typically only have ascii text, and are trying to annotate on a
> terminal. Or if user encoding is better, because they will tend to have
> ascii annotations anyway, and if they have non-ascii text, they have the
> best chance of being able to read it by redirecting to a file, and
> reading it there.
>
> My gut feeling is that 'get_user_encoding()' is better in this instance,
> which is why it is what my patch does.
>
John A Meinel пишет: terminal_ encoding( ) or get_user_encoding()
> fair enough. So the question becomes, what is more useful to you,
> Alexander. osutils.
I think the right solution is to use get_user_encoding()
because on Windows it equivalent to system default ANSI encoding.
If people don't satisfied with this encoding they *always*
can switch encoding of dos terminal with chcp command.
I use this command when I want to see in dos terminal
a diff for my non-ascii files.
> encoding( )' is going to be better because people encoding( )' is better in this instance,
> I realize you may not use 'bzr annotate' much. I'm just trying to figure
> out if 'terminal_
> typically only have ascii text, and are trying to annotate on a
> terminal. Or if user encoding is better, because they will tend to have
> ascii annotations anyway, and if they have non-ascii text, they have the
> best chance of being able to read it by redirecting to a file, and
> reading it there.
>
> My gut feeling is that 'get_user_
> which is why it is what my patch does.
>