Comment 3 for bug 786980

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 786980] Re: bzr: ERROR: bzrlib.errors.ReadOnlyError: A write attempt was made in a read only transaction

On Mon, 2011-05-23 at 13:16 +0000, Julian Edwards wrote:
> Crash log attached.
>
> ** Attachment added: "bzr.500.2011-05-23T13:10.crash"
> https://bugs.launchpad.net/bzr/+bug/786980/+attachment/2139605/+files/bzr.500.2011-05-23T13%3A10.crash
We shouldn't be trying to take a write lock on the master branch during
'bzr up'.

This code in InterBranch.push looks dodgy:

source_is_master = (self.source.user_url == bound_location)

I think we need to use has_same_location() there, as e.g. user_url might
have a slightly different URL (more or fewer slashes).

  status triaged
  importance high

Cheers,

Jelmer