Comment 6 for bug 755642

On Mon, 2011-04-11 at 08:26 +0000, John A Meinel wrote:
> On 4/10/2011 8:48 PM, Jelmer Vernooij wrote:
> > On Sat, 2011-04-09 at 16:37 +0000, Jelmer Vernooij wrote:
> >> Public bug reported:
> >>
> >> bzr-svn and bzr-git have started using testament sha's as ways to verify
> >> that revisions have roundtripped correctly. Unfortunately this process
> >> is very slow (taking up 90% of the time when fetching roundtripped
> >> revisions).
> >
> > This is also relevant for build from branch into primary, where we were
> > looking at using GPG signed testaments as a way of verifying the
> > authenticity of a revision.
> Except aren't you only caring about a single revision there? It takes
> maybe a second or 2 to compute a testament (I could see a bit more for
> large trees, but my iter_entries_by_dir() changes either helps a ton, or
> can be tweaked to help.)
>
> I don't think this would be a significant fraction of the time spent in
> BuildFromBranch.
No, but if we're changing the testament format then we should probably
make sure to do it before we start using the old format for bfbip.

Cheers,

Jelmer