Comment 5 for bug 755642

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 755642] [NEW] calculating testament sha1 is very slow

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 4/10/2011 8:48 PM, Jelmer Vernooij wrote:
> On Sat, 2011-04-09 at 16:37 +0000, Jelmer Vernooij wrote:
>> Public bug reported:
>>
>> bzr-svn and bzr-git have started using testament sha's as ways to verify
>> that revisions have roundtripped correctly. Unfortunately this process
>> is very slow (taking up 90% of the time when fetching roundtripped
>> revisions).
>
> This is also relevant for build from branch into primary, where we were
> looking at using GPG signed testaments as a way of verifying the
> authenticity of a revision.
>
> Cheers,
>
> Jelmer
>

Except aren't you only caring about a single revision there? It takes
maybe a second or 2 to compute a testament (I could see a bit more for
large trees, but my iter_entries_by_dir() changes either helps a ton, or
can be tweaked to help.)

I don't think this would be a significant fraction of the time spent in
BuildFromBranch.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2iux4ACgkQJdeBCYSNAANf2QCfVD8JvxnjvXd8ziKX7RiUVJgu
F5gAnjEE4fltOBK/Tbvd2d0H5WOTAjj6
=Xo7U
-----END PGP SIGNATURE-----